[vscode-go] tools/installtools: install old dlv for go1.16 and 1.17

[Hyang-Ah Hana Kim (Gerrit)]

Hyang-Ah Hana Kim submitted this change.

View Change

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: Suzy Mueller: Looks good to me, approved Hyang-Ah Hana Kim: Run TryBots kokoro: TryBots succeeded

tools/installtools: install old dlv for go1.16 and 1.17

Fixes golang/vscode-go#2572

Change-Id: Ic5bcdc6c01737267095d80bad7ac74f72c6905e7
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/459856
Run-TryBot: Hyang-Ah Hana Kim <hya...@gmail.com>
TryBot-Result: kokoro <noreply...@google.com>
Reviewed-by: Suzy Mueller <suz...@golang.org>
---
M .github/workflows/test-long.yml
M tools/installtools/main.go
2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/test-long.yml b/.github/workflows/test-long.yml
index 634ac58..1d903a8 100644
--- a/.github/workflows/test-long.yml
+++ b/.github/workflows/test-long.yml
@@ -41,7 +41,6 @@
       - name: Compile
         run: npm run vscode:prepublish
 
-      # TODO: use `go install` when we all move to 1.16+ (see build/all.bash)
       - name: Install Go tools (Modules mode)
         run: |
             go version
diff --git a/tools/installtools/main.go b/tools/installtools/main.go
index ca6d5ba..a2280aa 100644
--- a/tools/installtools/main.go
+++ b/tools/installtools/main.go
@@ -49,7 +49,7 @@
 	{"github.com/zmb3/gogetdoc", "", false, nil},
 	{"honnef.co/go/tools/cmd/staticcheck", "", false, []finalVersion{{16, "v0.2.2"}}},
 	{"golang.org/x/tools/cmd/gorename", "", false, nil},
-	{"github.com/go-delve/delve/cmd/dlv", "", false, nil},
+	{"github.com/go-delve/delve/cmd/dlv", "", false, []finalVersion{{16, "v1.8.3"}, {17, "v1.9.1"}}},
 }
 
 // pickVersion returns the version to install based on the supported

To view, visit change 459856. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: vscode-go

Gerrit-Branch: master

Gerrit-Change-Id: Ic5bcdc6c01737267095d80bad7ac74f72c6905e7

Gerrit-Change-Number: 459856

Gerrit-PatchSet: 3

Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>

Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>

Gerrit-Reviewer: Jamal Carvalho <ja...@golang.org>

Gerrit-Reviewer: Suzy Mueller <suz...@golang.org>

Gerrit-Reviewer: kokoro <noreply...@google.com>

Gerrit-MessageType: merged