[tools] gopls/benchmark: skip unimported completion if not local

0 views
Skip to first unread message

Peter Weinberger (Gerrit)

unread,
Dec 25, 2025, 11:57:59 AM (4 days ago) Dec 25
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alan Donovan, Go LUCI, golang-co...@googlegroups.com

Peter Weinberger submitted the change

Change information

Commit message:
gopls/benchmark: skip unimported completion if not local

This benchmark should only be run locally, where there is a usable
module cache (and index). Also, it had an obsolete calculation of
the location of the index.

For context, see
https://github.com/golang/go/issues/76873#issuecomment-3667491422
Change-Id: I5226671d789d38d67a40628d6886293d00f659fc
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
  • M gopls/internal/test/integration/bench/unimported_test.go
  • M internal/modindex/index.go
Change size: S
Delta: 2 files changed, 17 insertions(+), 11 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Alan Donovan
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I5226671d789d38d67a40628d6886293d00f659fc
Gerrit-Change-Number: 732000
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Weinberger <p...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Peter Weinberger <p...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages