[go] crypto/mldsa: remove hand-defined wycheproof structs

2 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Jul 2, 2026, 11:32:55 AM (2 days ago) Jul 2

to Daniel McCarney, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hongxiang Jiang, Dmitri Shuralyov, Dmitri Shuralyov, Filippo Valsorda, golang...@luci-project-accounts.iam.gserviceaccount.com, Roland Shoemaker, Neal Patel, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

crypto/mldsa: remove hand-defined wycheproof structs

Take a temporary replace directive in the go.mod for the
crypto/internal/cryptotest/wycheproof/_schema go.mod on
a yet-to-be-merged upstream fix to atombender/go-jsonschema. This fixes
a limitation where schemas with certain unmodelled properties (e.g.
conditional validation requirements) would result in the generated
code using a generic interface type instead of a structure.

With this in place the ML-DSA wycheproof test can lose its manually
defined structure + unmarshalling code in favour of using the generated
structure type that's always in-sync with upstream.

Change-Id: Ibbd7b41aaa0caf6414b319b77e62762b498ed6f8

Reviewed-on: https://go-review.googlesource.com/c/go/+/795301

Reviewed-by: Filippo Valsorda <fil...@golang.org>

Auto-Submit: Daniel McCarney <dan...@binaryparadox.net>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Hongxiang Jiang <hxj...@golang.org>

Files:

M src/crypto/internal/cryptotest/wycheproof/_schema/go.mod
M src/crypto/internal/cryptotest/wycheproof/_schema/go.sum
M src/crypto/internal/cryptotest/wycheproof/schema.go
M src/crypto/mldsa/mldsa_wycheproof_test.go

Change size: M

Delta: 4 files changed, 70 insertions(+), 45 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Hongxiang Jiang, +2 by Filippo Valsorda, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages