[go] syscall: copy only read bytes in js/wasm

0 views

Skip to first unread message

Cherry Mui (Gerrit)

unread,

11:14 AM (2 hours ago) 11:14 AM

to Rajiv Singh, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hyang-Ah Hana Kim, Johan Brandhorst-Satzkorn, golang...@luci-project-accounts.iam.gserviceaccount.com, Ian Lance Taylor, Gopher Robot, golang-co...@googlegroups.com

Cherry Mui submitted the change

Change information

Commit message:

syscall: copy only read bytes in js/wasm

CopyBytesToGo in Read and Pread copies the entire buffer instead of
only the n bytes actually returned by the read call. This is wasteful,
especially for small files where os.ReadFile uses a 512-byte buffer
but only a few bytes are read.

Copy only the bytes that were read, and skip the copy entirely when
zero bytes are returned.

Fixes #53566

Change-Id: I3109db5e8afe4f5ea53c9c0aa2724ff60e883ec1

Reviewed-on: https://go-review.googlesource.com/c/go/+/767680

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Cherry Mui <cher...@google.com>

Reviewed-by: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>

Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>

Files:

M src/syscall/fs_js.go

Change size: S

Delta: 1 file changed, 9 insertions(+), 4 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Hyang-Ah Hana Kim, +1 by Cherry Mui, +2 by Johan Brandhorst-Satzkorn
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages