[go] cmd/go/internal/modload: remove state manipulation functions

1 view

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Jul 23, 2026, 5:32:54 PM (3 days ago) Jul 23

to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Ian Alexander, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

cmd/go/internal/modload: remove state manipulation functions

Remove setState, EnterWorkspace, and Reset from the moudle loader. They're no
longer necessary because we can just create new loaders with jitsu's work
removing the use of global state!

Change-Id: I93146f3692a5d3077a6d8913d7ff501d6a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/801340

Auto-Submit: Michael Matloob <mat...@golang.org>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Michael Matloob <mat...@google.com>

Reviewed-by: Ian Alexander <ji...@google.com>

Files:

M src/cmd/go/internal/modget/get.go
M src/cmd/go/internal/modload/init.go
M src/cmd/go/internal/toolchain/select.go
M src/cmd/go/internal/workcmd/sync.go

Change size: M

Delta: 4 files changed, 16 insertions(+), 34 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Ian Alexander, +1 by Michael Matloob
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages