[tools] gopls/internal/filewatcher: add poll-based watcher

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

10:46 AM (12 hours ago) 10:46 AM

to Hongxiang Jiang, Alan Donovan, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

gopls/internal/filewatcher: add poll-based watcher

Update poll watcher to support watching multiple root directories.
It also ensures that WatchDir performs a synchronous scan to establish a
baseline state if one doesn't exist, preventing missed events on startup.

At this point, the coarse-grained locking mechanism is not ideal but
sufficient since the only competing method is "WatchDir" and should
not be called frequently.

The test for file watcher no longer test the OS specific event order,
e.g. "new file" creation first or "old file" deletion first in a file
rename. The test focus on the existence of the wanted events regardless
of the order.

Windows uses mandatory file locking, when the poll watcher is scanning
the dir, other processes can not operate on the same file. The file
watcher's test have also changed to try with backoff to make sure the
operation can survive any transient error.

For golang/go#77814 golang/go#76291