[tools] go/analysis/passes/modernize: treat 'i += 1' as 'i++'

[Hongxiang Jiang (Gerrit)]

Hongxiang Jiang submitted the change

Change information

Commit message:

go/analysis/passes/modernize: treat 'i += 1' as 'i++'

The rangeint modernize pass converts the first loop but not the second, despite
them being equivalent:

     for i := 0; i < 10; i++ {}
     for i := 0; i < 10; i += 1 {}

Teach the pass to permit i += 1, increasing the pass's usefulness.

Fixes golang/go#76977

Change-Id: I3e993b7d73c59cef8a3e672ca413bb16be897b1e

Reviewed-on: https://go-review.googlesource.com/c/tools/+/732500

Reviewed-by: Hongxiang Jiang <hxj...@golang.org>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Alan Donovan <adon...@google.com>

Files:

• M go/analysis/passes/modernize/rangeint.go
• M go/analysis/passes/modernize/testdata/src/rangeint/rangeint.go
• M go/analysis/passes/modernize/testdata/src/rangeint/rangeint.go.golden

Change size: S

Delta: 3 files changed, 41 insertions(+), 3 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Alan Donovan, +1 by Hongxiang Jiang
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: I3e993b7d73c59cef8a3e672ca413bb16be897b1e

Gerrit-Change-Number: 732500

Gerrit-PatchSet: 2

Gerrit-Owner: Matthew “strager” Glazar <str...@traduality.com>

Gerrit-Reviewer: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>

Gerrit-CC: Gopher Robot <go...@golang.org>