[go] cmd/link: fix AIX builds after recent linker changes

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Dec 8, 2025, 5:37:13 PM (4 days ago) Dec 8
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Cherry Mui, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
cmd/link: fix AIX builds after recent linker changes

This updates XCOFF-specific code for the recent addition
of funcdata to pclntab.

Because XCOFF puts separate symbols into separate csects,
each with their own alignment, it's important to tell the
external linker the expected alignment of each part of pclntab.
Otherwise the offsets within pclntab may change as the external
linker aligns symbols. This CL sets the correct alignment for
each pclntab child symbol, and sets pclntab's alignment to the
max of that of its children.

Tested on the GCC compile farm.

Fixes #76486
Change-Id: I77d8a90c4b4b79d80ca11ede8d9a2aa9cc89f53f
Auto-Submit: Ian Lance Taylor <ia...@golang.org>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: David Chase <drc...@google.com>
Files:
  • M src/cmd/link/internal/ld/pcln.go
  • M src/cmd/link/internal/ld/symtab.go
  • M src/cmd/link/internal/ld/xcoff.go
  • M src/cmd/link/link_test.go
  • M src/cmd/nm/nm_test.go
Change size: M
Delta: 5 files changed, 84 insertions(+), 63 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Cherry Mui, +1 by David Chase
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I77d8a90c4b4b79d80ca11ede8d9a2aa9cc89f53f
Gerrit-Change-Number: 725603
Gerrit-PatchSet: 3
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages