[vulndb] cmd/vulnreport: fix bug in duplicate-finding for triage

[Tatiana Bradley (Gerrit)]

Tatiana Bradley submitted the change

Change information

Commit message:

cmd/vulnreport: fix bug in duplicate-finding for triage

Fix a bug in which the "likely duplicate" label was applied
to all issues that have duplicates on the tracker. (For example,
if #1 and #2 both refer to GHSA-xxxx-yyyy-zzzz, only one of
these should be marked as a duplicate).

This also revealed some bugs in the fake in-memory implementation
of the GHSA API, which are now fixed.

Change-Id: Ifd98befdf3e23f1fc95df38533107de9c921b195

Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/599456

Reviewed-by: Damien Neil <dn...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• M cmd/vulnreport/find_aliases.go
• M cmd/vulnreport/lint.go
• M cmd/vulnreport/run_test.go
• M cmd/vulnreport/testdata/TestFix/no_change.txtar
• M cmd/vulnreport/testdata/TestTriage/all.txtar
• M cmd/vulnreport/testdata/issue_tracker.txtar
• M cmd/vulnreport/testdata/legacy_ghsas.txtar
• M cmd/vulnreport/triage.go

Change size: M

Delta: 8 files changed, 95 insertions(+), 31 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Damien Neil
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: vulndb

Gerrit-Branch: master

Gerrit-Change-Id: Ifd98befdf3e23f1fc95df38533107de9c921b195

Gerrit-Change-Number: 599456

Gerrit-PatchSet: 5

Gerrit-Owner: Tatiana Bradley <tatiana...@google.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Tatiana Bradley <tatiana...@google.com>