[go] encoding/json/v2: further clarify "string" wording
0 views
Skip to first unread message
Michael Pratt (Gerrit)
Aug 14, 2026, 1:11:12 PM (2 days ago) Aug 14
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Damien Neil, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Joseph Tsai, Jonathan Amsterdam, golang-co...@googlegroups.com
Michael Pratt submitted the change![]( "Open in Gerrit")
Change information
Commit message:
encoding/json/v2: further clarify "string" wording
Address comments from CL 813900, aiming to make it a bit more obvious
how errors apply, and why this option does not apply to composite types.
Also fix a minor grammar error on StringifyWithLegacySemantics.
For #71497.
Change-Id: I6ea4ddace3b398ad05169cdb5eda316c6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/813081
Reviewed-by: Joseph Tsai <joe...@digital-static.net>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dn...@google.com>
Reviewed-by: Jonathan Amsterdam <j...@google.com>
Files:
- M src/encoding/json/v2/doc.go
- M src/encoding/json/v2_options.go
Change size: S
Delta: 2 files changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Damien Neil, +2 by Joseph Tsai, +2 by Jonathan Amsterdam
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Aug 14, 2026, 11:41:01 PM (2 days ago) Aug 14
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Carlos Amedee, golang...@luci-project-accounts.iam.gserviceaccount.com, Damien Neil, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[release-branch.go1.27] encoding/json/v2: further clarify "string" wording
Address comments from CL 813900, aiming to make it a bit more obvious
how errors apply, and why this option does not apply to composite types.
Also fix a minor grammar error on StringifyWithLegacySemantics.
For #71497.
Change-Id: I6ea4ddace3b398ad05169cdb5eda316c6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/813081
Reviewed-by: Joseph Tsai <joe...@digital-static.net>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dn...@google.com>
Reviewed-by: Jonathan Amsterdam <j...@google.com>
(cherry picked from commit 981eb7e540d3a16db226c6cb2d2284ce84e4ba17)
Reviewed-on: https://go-review.googlesource.com/c/go/+/815521
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Auto-Submit: Michael Pratt <mpr...@google.com>
Auto-Submit: Dmitri Shuralyov <dmit...@google.com>
Files:
- M src/encoding/json/v2/doc.go
- M src/encoding/json/v2_options.go
Change size: S
Delta: 2 files changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/release-branch.go1.27
Submit Requirements:
Code-Review: +2 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages