[go] cmd/go/testdata/script: remove net condition from always skipped tests

0 views

Skip to first unread message

Michael Matloob (Gerrit)

unread,

2:54 PM (4 hours ago) 2:54 PM

to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com

Michael Matloob submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/cmd/go/testdata/script/mod_replace_gopkgin.txt
Insertions: 1, Deletions: 1.

@@ -5,7 +5,7 @@
 # gopkg.in path.
 
 skip 'skipping test that depends on an unreliable third-party server; see https://go.dev/issue/54503'
-# TODO(#54043): Make this work without needing the external network, and then re-enable.
+# TODO(#54503): Make this work without needing the external network, and then re-enable.
 [!git] skip
 
 env GO111MODULE=on
```

Change information

Commit message:

cmd/go/testdata/script: remove net condition from always skipped tests

mod_replace_gopkgin is unconditionally skipped, and there is an
unconditional skip in mod_replace_gopkgin. Remove the net condition
checks from these tests. We want to add an allowlist for the tests that
use net and make it as small as possible. Since these tests shouldn't
access the network once they're fixed and reenabled, just remove the
condition.

For #80243

Change-Id: I690e2668281901103b55f6d66eaa81816a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/795920

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>

Reviewed-by: Michael Matloob <mat...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M src/cmd/go/testdata/script/mod_gopkg_unstable.txt
M src/cmd/go/testdata/script/mod_replace_gopkgin.txt

Change size: XS

Delta: 2 files changed, 2 insertions(+), 5 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Michael Matloob, +2 by Dmitri Shuralyov, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages