[telemetry] internal/crashmonitor: fix TestViaStderr/trap

0 views

Skip to first unread message

Michael Stapelberg (Gerrit)

unread,

Oct 22, 2025, 10:57:43 AM (22 hours ago) Oct 22

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alan Donovan, Go LUCI, golang-co...@googlegroups.com

Michael Stapelberg submitted the change

Change information

Commit message:

internal/crashmonitor: fix TestViaStderr/trap

I believe there’s a mistake in commit 06ef541f:

What used to be:

    if got != want {
        t.Errorf("got counter name <<%s>>, want <<%s>>", got, want)
    }

became the following in TestViaStderr/panic:

    if !wantRE.MatchString(got) {
        t.Errorf("got counter name <<%s>>, want match for <<%s>>", got, wantRE)
    }

…but the condition was negated in TestViaStderr/trap:

   if wantRE.MatchString(got) {
       t.Errorf("got counter name <<%s>>, want match for <<%s>>", got, wantRE)
   }

This only went unnoticed because the crash stack line numbers are incorrect.

I noticed this when importing the x/telemetry package into google3,
where the package names are different and need an update.