[crypto] acme: only require prompt if server has terms of service

0 views
Skip to first unread message

Sean Liao (Gerrit)

unread,
Feb 13, 2026, 12:12:18 PMFeb 13
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Filippo Valsorda, Dmitri Shuralyov, Dmitri Shuralyov, Junyang Shao, Go LUCI, Michael Pratt, Daniel McCarney, Brad Fitzpatrick, Roland Shoemaker, Gopher Robot, golang-co...@googlegroups.com

Sean Liao submitted the change

Change information

Commit message:
acme: only require prompt if server has terms of service

Fixes golang/go#64881
Change-Id: I2b4415e6f987aab258c26c090ac7b1a465aa1697
Reviewed-by: Junyang Shao <shaoj...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Filippo Valsorda <fil...@golang.org>
Files:
  • M acme/autocert/autocert.go
  • M acme/autocert/autocert_test.go
  • M acme/autocert/internal/acmetest/ca.go
  • M acme/rfc8555.go
Change size: S
Delta: 4 files changed, 7 insertions(+), 6 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Junyang Shao, +2 by Filippo Valsorda, +1 by Dmitri Shuralyov
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crypto
Gerrit-Branch: master
Gerrit-Change-Id: I2b4415e6f987aab258c26c090ac7b1a465aa1697
Gerrit-Change-Number: 719001
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Liao <se...@liao.dev>
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Daniel McCarney <dan...@binaryparadox.net>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Filippo Valsorda <fil...@golang.org>
Gerrit-Reviewer: Junyang Shao <shaoj...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-CC: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages