[go] cmd/compile/internal/syntax,go/scanner: change interpretation of relative //line directives

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

2:26 PM (3 hours ago) 2:26 PM

to Michael Podtserkovskii, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alan Donovan, Robert Griesemer, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

cmd/compile/internal/syntax: resolve //line filenames relative to source directory

The behaviour of the compiler and go/scanner is unified:
Relative //line directives are now relative to the directory of
the scanned file.

Fixes #70478

Change-Id: I804edbb5f9540d386e0fb1a4e64b10b717125d1b

Reviewed-on: https://go-review.googlesource.com/c/go/+/706795

Reviewed-by: Alan Donovan <adon...@google.com>

Reviewed-by: Robert Griesemer <g...@google.com>

Auto-Submit: Robert Griesemer <g...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M doc/next/5-toolchain.md
M src/cmd/compile/doc.go
M src/cmd/compile/internal/syntax/parser.go
M src/cmd/compile/internal/syntax/parser_test.go
A src/cmd/go/testdata/script/build_line_directive_relative.txt
M src/cmd/internal/testdir/testdir_test.go
M test/fixedbugs/issue18149.go
M test/fixedbugs/issue22660.go
M test/fixedbugs/issue22662.go
M test/fixedbugs/issue22662b.go

Change size: M

Delta: 10 files changed, 190 insertions(+), 13 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Alan Donovan, +2 by Robert Griesemer
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages