[go] runtime: remove pageAlloc.scav padding for atomic field alignment

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Aug 19, 2022, 11:53:52 AM8/19/22

to Cuong Manh Le, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Joedian Reid, Michael Knyszek, Michael Pratt, golang-co...@googlegroups.com

Gopher Robot submitted this change.

View Change

Approvals:
  Michael Knyszek: Looks good to me, approved
  Cuong Manh Le: Run TryBots; Automatically submit change
  Gopher Robot: TryBots succeeded
  Joedian Reid: Looks good to me, but someone else must approve

runtime: remove pageAlloc.scav padding for atomic field alignment

CL 404096 makes atomic.Int64 8 bytes aligned everywhere.

Change-Id: I5a676f646260d6391bb071f9376cbdb1553e6e6f
Reviewed-on: https://go-review.googlesource.com/c/go/+/424925
Auto-Submit: Cuong Manh Le <cuong.m...@gmail.com>
Reviewed-by: Joedian Reid <joe...@golang.org>
TryBot-Result: Gopher Robot <go...@golang.org>
Run-TryBot: Cuong Manh Le <cuong.m...@gmail.com>
Reviewed-by: Michael Knyszek <mkny...@google.com>
---
M src/runtime/mpagealloc.go
1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/src/runtime/mpagealloc.go b/src/runtime/mpagealloc.go
index 5de25cf..bb30b4a 100644
--- a/src/runtime/mpagealloc.go
+++ b/src/runtime/mpagealloc.go
@@ -280,8 +280,6 @@
 		// Updated atomically.
 		released uintptr
 
-		_ uint32 // Align assistTime for atomics on 32-bit platforms.
-
 		// scavengeAssistTime is the time spent scavenging in the last GC cycle.
 		//
 		// This is reset once a GC cycle ends.

To view, visit change 424925. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

0 new messages