[go] cmd/internal/script: help deflake "WaitDelay expired" errors by reporting the duration

0 views

Skip to first unread message

t hepudds (Gerrit)

unread,

Jun 5, 2026, 2:25:44 PM (2 days ago) Jun 5

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Mark Freeman, Michael Matloob, Carlos Amedee, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

t hepudds submitted the change

Unreviewed changes

5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

cmd/internal/script: help deflake "WaitDelay expired" errors by reporting the duration

Issue #76685 has many watchflake reports that include the error
"WaitDelay expired". I have been able to reproduce some of those flakes.

The cmd/link testscripts have the highest volume on #76685, such as:
    script_test_basics.txt:6: cc -c testdata/mumble.c: exec: WaitDelay expired before I/O complete

To help triage, this CL adds the os/exec.Cmd.WaitDelay duration to
the error string. That sample error becomes:
    script_test_basics.txt:6: cc -c testdata/mumble.c: exec: WaitDelay expired before I/O complete: output pipes not closed after waiting 100ms

The 100ms shown is a concrete clue that the WaitDelay could be higher.
The next CL 785722 attempts to address that, hopefully eliminating those
particular flakes.

This code path is used by cmd/link tests, as well as testscript tests
in cmd/go, cmd/compile, cmd/internal/fuzztest, and cmd/internal/test2json.

Updates #76685
Updates #79409

Change-Id: Ib03dceccb839dc7653b86ca977e1a54bb48e7ead

Reviewed-on: https://go-review.googlesource.com/c/go/+/785820

Reviewed-by: Mark Freeman <markf...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Michael Matloob <mat...@golang.org>

Reviewed-by: Carlos Amedee <car...@golang.org>

Files:

M src/cmd/internal/script/cmds.go

Change size: XS

Delta: 1 file changed, 3 insertions(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Carlos Amedee, +2 by Michael Matloob, +1 by Mark Freeman
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages