[go] internal/trace: move v2 up one level

0 views
Skip to first unread message

Carlos Amedee (Gerrit)

unread,
May 17, 2024, 2:48:26 PMMay 17
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Michael Knyszek, Michael Pratt, golang-co...@googlegroups.com

Carlos Amedee submitted the change with unreviewed changes

Unreviewed changes

7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/internal/trace/mkexp.bash
Insertions: 0, Deletions: 50.

The diff is too large to show. Please review the diff.
```
```
The name of the file: src/runtime/crash_test.go
Insertions: 4, Deletions: 4.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:
internal/trace: move v2 tracer into trace directory

This change moves the v2 tracer into the trace directory.

Updates #67367
Change-Id: I3657b4227002cb00fdf29c797434800ea796715e
Reviewed-by: Michael Knyszek <mkny...@google.com>
Files:
  • M src/cmd/trace/gen.go
  • M src/cmd/trace/goroutinegen.go
  • M src/cmd/trace/goroutines.go
  • M src/cmd/trace/gstate.go
  • M src/cmd/trace/jsontrace.go
  • M src/cmd/trace/jsontrace_test.go
  • M src/cmd/trace/main.go
  • M src/cmd/trace/pprof.go
  • M src/cmd/trace/procgen.go
  • M src/cmd/trace/regions.go
  • M src/cmd/trace/tasks.go
  • M src/cmd/trace/testdata/mktests.go
  • M src/cmd/trace/threadgen.go
  • M src/cmd/trace/viewer.go
  • M src/go/build/deps_test.go
  • R src/internal/trace/base.go
  • R src/internal/trace/batch.go
  • R src/internal/trace/batchcursor.go
  • R src/internal/trace/batchcursor_test.go
  • R src/internal/trace/event.go
  • R src/internal/trace/event/event.go
  • R src/internal/trace/event/go122/event.go
  • R src/internal/trace/event/requirements.go
  • R src/internal/trace/event_test.go
  • A src/internal/trace/export_test.go
  • M src/internal/trace/gc.go
  • M src/internal/trace/gc_test.go
  • R src/internal/trace/generation.go
  • R src/internal/trace/internal/oldtrace/order.go
  • R src/internal/trace/internal/oldtrace/parser.go
  • R src/internal/trace/internal/oldtrace/parser_test.go
  • R src/internal/trace/internal/oldtrace/testdata/fmt_1_21_pprof_good
  • R src/internal/trace/internal/oldtrace/testdata/http_1_19_good
  • R src/internal/trace/internal/oldtrace/testdata/http_1_21_good
  • R src/internal/trace/internal/oldtrace/testdata/stress_1_11_good
  • R src/internal/trace/internal/oldtrace/testdata/stress_1_19_good
  • R src/internal/trace/internal/oldtrace/testdata/stress_1_21_good
  • R src/internal/trace/internal/oldtrace/testdata/stress_start_stop_1_11_good
  • R src/internal/trace/internal/oldtrace/testdata/stress_start_stop_1_19_good
  • R src/internal/trace/internal/oldtrace/testdata/stress_start_stop_1_21_good
  • R src/internal/trace/internal/oldtrace/testdata/user_task_region_1_11_good
  • R src/internal/trace/internal/oldtrace/testdata/user_task_region_1_19_good
  • R src/internal/trace/internal/oldtrace/testdata/user_task_region_1_21_good
  • R src/internal/trace/internal/testgen/go122/trace.go
  • M src/internal/trace/mud_test.go
  • R src/internal/trace/oldtrace.go
  • R src/internal/trace/oldtrace_test.go
  • R src/internal/trace/order.go
  • R src/internal/trace/order_test.go
  • R src/internal/trace/raw/doc.go
  • R src/internal/trace/raw/event.go
  • R src/internal/trace/raw/reader.go
  • R src/internal/trace/raw/textreader.go
  • R src/internal/trace/raw/textwriter.go
  • R src/internal/trace/raw/writer.go
  • R src/internal/trace/reader.go
  • R src/internal/trace/reader_test.go
  • R src/internal/trace/resources.go
  • M src/internal/trace/summary.go
  • M src/internal/trace/summary_test.go
  • R src/internal/trace/testdata/README.md
  • R src/internal/trace/testdata/cmd/cmd/gotraceeventstats/main.go
  • R src/internal/trace/testdata/cmd/gotraceraw/main.go
  • R src/internal/trace/testdata/cmd/gotracevalidate/main.go
  • R src/internal/trace/testdata/fuzz/FuzzReader/0cb1786dee0f090b
  • R src/internal/trace/testdata/fuzz/FuzzReader/1e45307d5b2ec36d
  • R src/internal/trace/testdata/fuzz/FuzzReader/2b05796f9b2fc48d
  • R src/internal/trace/testdata/fuzz/FuzzReader/2b9be9aebe08d511
  • R src/internal/trace/testdata/fuzz/FuzzReader/344331b314da0b08
  • R src/internal/trace/testdata/fuzz/FuzzReader/365d7b5b633b3f97
  • R src/internal/trace/testdata/fuzz/FuzzReader/4055b17cae1a3443
  • R src/internal/trace/testdata/fuzz/FuzzReader/4d9ddc909984e871
  • R src/internal/trace/testdata/fuzz/FuzzReader/56f073e57903588c
  • R src/internal/trace/testdata/fuzz/FuzzReader/9d6ee7d3ddf8d566
  • R src/internal/trace/testdata/fuzz/FuzzReader/aeb749b6bc317b66
  • R src/internal/trace/testdata/fuzz/FuzzReader/closing-unknown-region
  • R src/internal/trace/testdata/fuzz/FuzzReader/d478e18d2d6756b7
  • R src/internal/trace/testdata/fuzz/FuzzReader/d91203cd397aa0bc
  • R src/internal/trace/testdata/fuzz/FuzzReader/invalid-proc-state
  • R src/internal/trace/testdata/fuzz/FuzzReader/large-id
  • R src/internal/trace/testdata/fuzz/FuzzReader/malformed-timestamp
  • R src/internal/trace/testdata/generate.go
  • R src/internal/trace/testdata/generators/go122-confuse-seq-across-generations.go
  • R src/internal/trace/testdata/generators/go122-create-syscall-reuse-thread-id.go
  • R src/internal/trace/testdata/generators/go122-create-syscall-with-p.go
  • R src/internal/trace/testdata/generators/go122-fail-first-gen-first.go
  • R src/internal/trace/testdata/generators/go122-go-create-without-running-g.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-ambiguous.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-gen-boundary-bare-m.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-gen-boundary-reacquire-new-proc-bare-m.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-gen-boundary-reacquire-new-proc.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-gen-boundary.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-reacquire-new-proc-bare-m.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-reacquire-new-proc.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-self.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-simple-bare-m.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-simple.go
  • R src/internal/trace/testdata/generators/go122-syscall-steal-proc-sitting-in-syscall.go
  • R src/internal/trace/testdata/generators/go122-task-across-generations.go
  • R src/internal/trace/testdata/mktests.go
  • R src/internal/trace/testdata/testprog/annotations-stress.go
  • R src/internal/trace/testdata/testprog/annotations.go
  • R src/internal/trace/testdata/testprog/cgo-callback.go
  • R src/internal/trace/testdata/testprog/cpu-profile.go
  • R src/internal/trace/testdata/testprog/futile-wakeup.go
  • R src/internal/trace/testdata/testprog/gc-stress.go
  • R src/internal/trace/testdata/testprog/gomaxprocs.go
  • R src/internal/trace/testdata/testprog/iter-pull.go
  • R src/internal/trace/testdata/testprog/many-start-stop.go
  • R src/internal/trace/testdata/testprog/stacks.go
  • R src/internal/trace/testdata/testprog/stress-start-stop.go
  • R src/internal/trace/testdata/testprog/stress.go
  • R src/internal/trace/testdata/testprog/wait-on-pipe.go
  • R src/internal/trace/testdata/tests/go122-annotations-stress.test
  • R src/internal/trace/testdata/tests/go122-annotations.test
  • R src/internal/trace/testdata/tests/go122-confuse-seq-across-generations.test
  • R src/internal/trace/testdata/tests/go122-create-syscall-reuse-thread-id.test
  • R src/internal/trace/testdata/tests/go122-create-syscall-with-p.test
  • R src/internal/trace/testdata/tests/go122-fail-first-gen-first.test
  • R src/internal/trace/testdata/tests/go122-gc-stress.test
  • R src/internal/trace/testdata/tests/go122-go-create-without-running-g.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-ambiguous.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-gen-boundary-bare-m.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-gen-boundary-reacquire-new-proc-bare-m.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-gen-boundary-reacquire-new-proc.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-gen-boundary.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-reacquire-new-proc-bare-m.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-reacquire-new-proc.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-self.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-simple-bare-m.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-simple.test
  • R src/internal/trace/testdata/tests/go122-syscall-steal-proc-sitting-in-syscall.test
  • R src/internal/trace/testdata/tests/go122-task-across-generations.test
  • R src/internal/trace/testtrace/expectation.go
  • R src/internal/trace/testtrace/format.go
  • R src/internal/trace/testtrace/validation.go
  • R src/internal/trace/trace_test.go
  • D src/internal/trace/v2/mkexp.bash
  • R src/internal/trace/value.go
  • R src/internal/trace/version/version.go
  • M src/runtime/crash_test.go
  • M src/runtime/trace_cgo_test.go
Change size: XL
Delta: 142 files changed, 554 insertions(+), 598 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Michael Knyszek
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I3657b4227002cb00fdf29c797434800ea796715e
Gerrit-Change-Number: 584538
Gerrit-PatchSet: 9
Gerrit-Owner: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages