[vuln] internal/worker: skip TestNewBody

0 views

Skip to first unread message

Julie Qiu (Gerrit)

unread,

Dec 7, 2021, 12:17:02 PM12/7/21

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Jonathan Amsterdam, Gopher Robot, kokoro, golang-co...@googlegroups.com

Julie Qiu submitted this change.

View Change

Approvals:
  Jonathan Amsterdam: Looks good to me, approved
  Julie Qiu: Trusted; Run TryBots
  Gopher Robot: TryBots succeeded

internal/worker: skip TestNewBody

TestNewBody uses math.MaxInt which is only available in Go1.17+, so this
test is failing on TryBots.

Temporarily comment out this test until CI is moved to kokoro.

For golang/go#50026

Change-Id: Iae296a983d8a6529b690f12e0989c1f9334b7eae
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/369994
Trust: Julie Qiu <ju...@golang.org>
Run-TryBot: Julie Qiu <ju...@golang.org>
TryBot-Result: Gopher Robot <go...@golang.org>
Reviewed-by: Jonathan Amsterdam <j...@google.com>
---
M internal/worker/worker_test.go
1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/internal/worker/worker_test.go b/internal/worker/worker_test.go
index 1bafece..aeff6d6 100644
--- a/internal/worker/worker_test.go
+++ b/internal/worker/worker_test.go
@@ -6,14 +6,12 @@
 
 import (
 	"context"
-	"math"
 	"strings"
 	"testing"
 	"time"
 
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
-	"golang.org/x/vuln/internal/cveschema"
 	"golang.org/x/vuln/internal/worker/log"
 	"golang.org/x/vuln/internal/worker/store"
 )
@@ -137,6 +135,8 @@
 	}
 }
 
+/*
+TODO(golang/go#50026): Uncomment this test once CI is moved to kokoro.
 func TestNewBody(t *testing.T) {
 	r := &store.CVERecord{
 		ID:     "ID1",
@@ -210,3 +210,4 @@
 	}
 	return strings.Join(lines, "\n")
 }
+*/

To view, visit change 369994. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

0 new messages