[go] cmd/compile: add loclist for pruned reg ret params

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Feb 24, 2026, 3:51:40 PM (13 hours ago) Feb 24
to Derek Parker, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Keith Randall, Keith Randall, Go LUCI, Than McIntosh, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
cmd/compile: add loclist for removed DCL nodes

Certain return parameters which live in registers and end up pruned by
earlier SSA passes will end up with a DWARF entry but no location list.
This patch fixes this by ensuring those params have proper location
lists generated for them.
Change-Id: I4fff074e62c3010abdee85934fb286510b21c707
Auto-Submit: Keith Randall <k...@golang.org>
Reviewed-by: Keith Randall <k...@golang.org>
Reviewed-by: David Chase <drc...@google.com>
Reviewed-by: Keith Randall <k...@google.com>
Reviewed-by: Derek Parker <parker...@gmail.com>
Files:
  • M src/cmd/compile/internal/dwarfgen/dwarf.go
  • M src/cmd/compile/internal/ssa/config.go
  • M src/cmd/compile/internal/ssa/debug.go
  • M src/cmd/compile/internal/ssagen/ssa.go
  • M src/cmd/link/dwarf_test.go
Change size: M
Delta: 5 files changed, 201 insertions(+), 15 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Keith Randall, +1 by David Chase, +1 by Derek Parker, +2 by Keith Randall
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I4fff074e62c3010abdee85934fb286510b21c707
Gerrit-Change-Number: 696575
Gerrit-PatchSet: 15
Gerrit-Owner: Derek Parker <parker...@gmail.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Derek Parker <parker...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@google.com>
Gerrit-Reviewer: Than McIntosh <th...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages