[go] cmd/dist: preserve existing GOEXPERIMENTs when running tests with additional experiments

[Quim Muntal (Gerrit)]

Quim Muntal submitted the change

Change information

Commit message:

cmd/dist: preserve existing GOEXPERIMENTs when running tests with additional experiments

Some tests require enabling specific Go experiments via the GOEXPERIMENT
, like "jsonv2", "runtimesecret", or "simd".

When running these tests, we should preserve any existing GOEXPERIMENT
settings, so that multiple experiments can be tested together.

I've found this limitation while working in my own Go fork, where in
some situations I pass additional experiments to the tests that alter
the Go runtime and other core packages.

Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33

Reviewed-on: https://go-review.googlesource.com/c/go/+/730360

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Cherry Mui <cher...@google.com>

Reviewed-by: Michael Knyszek <mkny...@google.com>

Files:

• M src/cmd/dist/test.go

Change size: S

Delta: 1 file changed, 19 insertions(+), 3 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Cherry Mui, +1 by Michael Knyszek
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33

Gerrit-Change-Number: 730360

Gerrit-PatchSet: 4

Gerrit-Owner: Quim Muntal <quimm...@gmail.com>

Gerrit-Reviewer: Cherry Mui <cher...@google.com>

Gerrit-Reviewer: David Chase <drc...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>

Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>