[tools] gopls/internal/test: have semtok work with gopls@v0.11.0

0 views

Skip to first unread message

Alex Putman (Gerrit)

unread,

Jul 1, 2026, 2:18:06 PM (3 days ago) Jul 1

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Madeline Kalil, golang-co...@googlegroups.com

Alex Putman submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

gopls/internal/test: have semtok work with go...@v0.11.0

Previously in gopls v0.11.0, the gopls server only registered SemanticTokens as a dynamic registration. Meaning that the option `capabilities.TextDocument.SemanticTokens.DynamicRegistration` had to be `true` and the client had to be set up to handle it being dynamically registered; i.e. in the `RegisterCapability` callback.

So by implementing this functionality again on the client (which shouldn't be an issue since it is just supporting an additional server configuration), the benchmarks now work again for the baseline version. Tested running the command:

```
> cd gopls/internal/test/integration/bench

> go test -test.fullpath=true -benchmem -run=^$ -gopls_commit=gopls/v0.11.0 -bench ^BenchmarkSemanticTokens$ golang.org/x/tools/gopls/internal/test/integration/bench  
```

Change-Id: Iecf9efad800e4c9d0322f6288ee2ee106a6a6964

Reviewed-on: https://go-review.googlesource.com/c/tools/+/795701

Reviewed-by: Madeline Kalil <mka...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files: