[tools] gopls/test/completion: construct index explicitly

0 views
Skip to first unread message

Peter Weinberger (Gerrit)

unread,
Jul 24, 2026, 10:56:30 AM (2 days ago) Jul 24
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Madeline Kalil, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Peter Weinberger submitted the change

Change information

Commit message:
gopls/test/completion: construct index explicitly

TestIssue61208 is flaky because it relies on a background go routine
finishing before the index is needed.

Instead of hoping, explicity ensure the index exists.
Fixes: golang/go#80551
Change-Id: I73512131277fd8f69e6fe9d80947288f9c2c3262
Reviewed-by: Madeline Kalil <mka...@google.com>
Files:
  • M gopls/internal/test/integration/completion/completion_test.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I73512131277fd8f69e6fe9d80947288f9c2c3262
Gerrit-Change-Number: 805040
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Weinberger <p...@google.com>
Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
Gerrit-Reviewer: Peter Weinberger <p...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages