[tools] gopls/doc/release: add semantic token config change

7 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Jan 21, 2025, 2:45:02 PMJan 21

to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Alan Donovan, Robert Findley, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: gopls/doc/release/v0.18.0.md
Insertions: 7, Deletions: 7.

@@ -14,21 +14,21 @@
   types. It allows disabling types by setting each value to false. By default,
   all types are enabled.
 
-- The experimental `settings.semanticTokenModifiers` configures the semantic
+  The experimental `settings.semanticTokenModifiers` configures the semantic
   token modifiers. It allows disabling modifiers by setting each value to false.
   By default, all modifiers are enabled.
 
-- The experimental `settings.noSemanticTokenString` and
-  `settings.noSemanticToken` settings are being deprecated in favor of
+  The experimental `settings.noSemanticTokenString` and
+  `settings.noSemanticToken` settings are deprecated in favor of
   `settings.semanticTokenTypes`.
 
   Users can set `settings.semanticTokenTypes[string] = false` to achieve the
-  same result as `settings.noSemanticTokenString`. Same applies to
+  same result as `settings.noSemanticTokenString`. The same applies to
   `settings.noSemanticTokenNumber`.
 
-  For now, gopls will still honor `settings.noSemanticTokenString` and
-  `settings.noSemanticToken` and will stop honoring the settings in the upcoming
-  release. Please update your configurations accordingly.
+  For now, gopls still honors `settings.noSemanticTokenString` and
+  `settings.noSemanticToken`, but will stop honoring the settings in the
+  upcoming release.
 
 # New features
 
```

Change information

Commit message:

gopls/doc/release: add semantic token config change

For golang/vscode-go#3632

Change-Id: I8d8a219c380ac8ac07a1baaef3bc89701894b985

Reviewed-on: https://go-review.googlesource.com/c/tools/+/643497

Reviewed-by: Alan Donovan <adon...@google.com>

Auto-Submit: Hongxiang Jiang <hxj...@golang.org>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M gopls/doc/release/v0.18.0.md

Change size: S

Delta: 1 file changed, 20 insertions(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages