[vscode-go] extension/test/gopls: add implement interface test

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Aug 14, 2026, 3:18:29 PM (2 days ago) Aug 14
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Madeline Kalil, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
extension/test/gopls: add implement interface test

Make vscode command "go.impl.cursor" await the completion of the
document edit before resolving.

This test is testing the behavior for the vscode command execution
using the third party tool impl. The test is added to make sure the
behavior remain mostly the same before and after the future change.

For golang/vscode-go#4063
Change-Id: Ib1d8c40c92ce878c35ec153dfbe1aa06ef8c8a36
Auto-Submit: Hongxiang Jiang <hxj...@golang.org>
Reviewed-by: Madeline Kalil <mka...@google.com>
Files:
  • M extension/src/goImpl.ts
  • M extension/test/gopls/interactive.test.ts
  • M extension/tools/installtools/main.go
Change size: M
Delta: 3 files changed, 59 insertions(+), 23 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: vscode-go
Gerrit-Branch: master
Gerrit-Change-Id: Ib1d8c40c92ce878c35ec153dfbe1aa06ef8c8a36
Gerrit-Change-Number: 815540
Gerrit-PatchSet: 5
Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages