[go] crypto/des: correct finalPermutation comment from 4-bit to 64-bit

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Feb 9, 2026, 6:23:45 PMFeb 9
to shuang cui, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, Roland Shoemaker, Filippo Valsorda, Ian Lance Taylor, Go LUCI, Daniel McCarney, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
crypto/des: correct finalPermutation comment from 4-bit to 64-bit

The finalPermutation array operates on a 64-bit preoutput block,
not a 4-bit block. This updates the comment to accurately
reflect the size of the data being processed in the DES
algorithm's final permutation step.
Change-Id: Ib6a5828a2e72d8bc8d04a3d413eaac320c15df15
Reviewed-by: Roland Shoemaker <rol...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Filippo Valsorda <fil...@golang.org>
Auto-Submit: Filippo Valsorda <fil...@golang.org>
Files:
  • M src/crypto/des/const.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dmitri Shuralyov, +2 by Filippo Valsorda, +1 by Roland Shoemaker
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ib6a5828a2e72d8bc8d04a3d413eaac320c15df15
Gerrit-Change-Number: 730020
Gerrit-PatchSet: 2
Gerrit-Owner: shuang cui <imc...@gmail.com>
Gerrit-Reviewer: Daniel McCarney <dan...@binaryparadox.net>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Filippo Valsorda <fil...@golang.org>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
Gerrit-Reviewer: shuang cui <imc...@gmail.com>
Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages