Groups
Groups
Sign in
Groups
Groups
golang-checkins
Conversations
About
Send feedback
Help
[tools] gopls/internal/golang: fix crash in canExtractVariable
0 views
Skip to first unread message
Alan Donovan (Gerrit)
unread,
Nov 10, 2025, 4:47:58 PM (2 days ago)
Nov 10
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Robert Findley, Go LUCI, golang-co...@googlegroups.com
Alan Donovan submitted the change
Change information
Commit message:
gopls/internal/golang: fix crash in canExtractVariable
+ test
Fixes golang/go#76235
Change-Id:
I273630214d31adfe989890573cc1a680a694eca5
Reviewed-on:
https://go-review.googlesource.com/c/tools/+/719261
LUCI-TryBot-Result:
Go LUCI <
golang...@luci-project-accounts.iam.gserviceaccount.com
>
Auto-Submit:
Alan Donovan <
adon...@google.com
>
Reviewed-by:
Robert Findley <
rfin...@google.com
>
Files:
M gopls/internal/golang/extract.go
M gopls/internal/test/integration/misc/codeactions_test.go
Change size:
S
Delta:
2 files changed, 16 insertions(+), 1 deletion(-)
Branch:
refs/heads/master
Submit Requirements:
Code-Review:
+2
by
Robert Findley
TryBots-Pass:
LUCI-TryBot-Result+1
by
Go LUCI
Open in Gerrit
Inspect html for
hidden footers
to help with email filtering. To unsubscribe visit
settings
.
Gerrit
Gerrit-MessageType: merged
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I273630214d31adfe989890573cc1a680a694eca5
Gerrit-Change-Number: 719261
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Donovan <
adon...@google.com
>
Gerrit-Reviewer: Alan Donovan <
adon...@google.com
>
Gerrit-Reviewer: Go LUCI <
golang...@luci-project-accounts.iam.gserviceaccount.com
>
Gerrit-Reviewer: Robert Findley <
rfin...@google.com
>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages