[go] database/sql: ensure Null* types have Valid=false when Scan returns error
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Feb 6, 2026, 3:11:04 PM (2 days ago) Feb 6
to Ravi Sastry Kadali, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, Michael Pratt, Go LUCI, Emmanuel Odeke, Daniel Theophanes, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
database/sql: ensure Null* types have Valid=false when Scan returns error
The Scan methods for NullString, NullInt64, NullInt32, NullFloat64,
NullBool, and NullTime set Valid=true before calling convertAssign.
If convertAssign returns an error, Valid remains true, which creates
an inconsistent state where Valid=true but err!=nil.
Fix by setting Valid only after successful conversion.
Fixes #45662
Change-Id: I855a20abbe517ed017f7c9b8f5603b17bd9d487d
Reviewed-on: https://go-review.googlesource.com/c/go/+/739160
Auto-Submit: Sean Liao <se...@liao.dev>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Sean Liao <se...@liao.dev>
Reviewed-by: Michael Pratt <mpr...@google.com>
Files:
- M src/database/sql/sql.go
- M src/database/sql/sql_test.go
Change size: M
Delta: 2 files changed, 170 insertions(+), 14 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Sean Liao, +1 by Michael Pratt, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages