[go/release-branch.go1.25] [release-branch.go1.25] runtime: mark getfp as nosplit

0 views
Skip to first unread message

Cherry Mui (Gerrit)

unread,
Dec 29, 2025, 8:52:06 PM (8 hours ago) Dec 29
to Keith Randall, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Keith Randall, golang-co...@googlegroups.com

Cherry Mui submitted the change

Change information

Commit message:
[release-branch.go1.25] runtime: mark getfp as nosplit

When compiling with -l, we can't take a stack split here.

Fixes #76761

Change-Id: Ieab1225c6259c7f16bb5188aa84bff615d9db2e5
Reviewed-on: https://go-review.googlesource.com/c/go/+/728060
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Keith Randall <k...@golang.org>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Keith Randall <k...@google.com>
(cherry picked from commit d4972f6295aede2ddc35bcb1da5f6351623e9e4d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/728581
Files:
  • M src/runtime/os_wasm.go
  • M src/runtime/stubs_386.go
  • M src/runtime/stubs_arm.go
  • M src/runtime/stubs_loong64.go
  • M src/runtime/stubs_mips64x.go
  • M src/runtime/stubs_mipsx.go
  • M src/runtime/stubs_ppc64x.go
  • M src/runtime/stubs_riscv64.go
  • M src/runtime/stubs_s390x.go
Change size: S
Delta: 9 files changed, 18 insertions(+), 0 deletions(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Keith Randall, +2 by Cherry Mui
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.25
Gerrit-Change-Id: Ieab1225c6259c7f16bb5188aa84bff615d9db2e5
Gerrit-Change-Number: 728581
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@google.com>
open
diffy
satisfied_requirement

Cherry Mui (Gerrit)

unread,
Dec 29, 2025, 8:52:22 PM (8 hours ago) Dec 29
to Keith Randall, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Keith Randall, golang-co...@googlegroups.com

Cherry Mui submitted the change

Change information

Commit message:
[release-branch.go1.24] runtime: mark getfp as nosplit


When compiling with -l, we can't take a stack split here.

Fixes #76760


Change-Id: Ieab1225c6259c7f16bb5188aa84bff615d9db2e5
Reviewed-on: https://go-review.googlesource.com/c/go/+/728060
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Keith Randall <k...@golang.org>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Keith Randall <k...@google.com>
(cherry picked from commit d4972f6295aede2ddc35bcb1da5f6351623e9e4d)
Files:
  • M src/runtime/os_wasm.go
  • M src/runtime/stubs_386.go
  • M src/runtime/stubs_arm.go
  • M src/runtime/stubs_loong64.go
  • M src/runtime/stubs_mips64x.go
  • M src/runtime/stubs_mipsx.go
  • M src/runtime/stubs_ppc64x.go
  • M src/runtime/stubs_riscv64.go
  • M src/runtime/stubs_s390x.go
Change size: S
Delta: 9 files changed, 18 insertions(+), 0 deletions(-)
Branch: refs/heads/release-branch.go1.24
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Keith Randall, +2 by Cherry Mui
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.24
Gerrit-Change-Id: Ieab1225c6259c7f16bb5188aa84bff615d9db2e5
Gerrit-Change-Number: 728580
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages