[go/release-branch.go1.26] [release-branch.go1.26] cmd/go/internal/cache: update trim timestamp before trimming

0 views
Skip to first unread message

Carlos Amedee (Gerrit)

unread,
12:39 PM (9 hours ago) 12:39 PM
to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, Go LUCI, Mark Freeman, Alan Donovan, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:
[release-branch.go1.26] cmd/go/internal/cache: update trim timestamp before trimming

This reduces the chance that multiple go commands running in CI will
try to trim at the same time, causing contention and slowing things
down.

For #76314
Fixes #78058

Change-Id: I3edf818fc9583795f3f51b715fdbe75b6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/753240
Reviewed-by: Michael Matloob <mat...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Matloob <mat...@google.com>
Reviewed-by: Alan Donovan <adon...@google.com>
(cherry picked from commit 2a5890cd46e5658b5ceab6cfd7a06b3bfe947fb9)
Reviewed-on: https://go-review.googlesource.com/c/go/+/753701
Reviewed-by: Mark Freeman <markf...@google.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Files:
  • M src/cmd/go/internal/cache/cache.go
Change size: S
Delta: 1 file changed, 31 insertions(+), 10 deletions(-)
Branch: refs/heads/release-branch.go1.26
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Alan Donovan, +1 by Mark Freeman, +1 by Cherry Mui
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI, TryBot-Bypass+0 by Mark Freeman
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.26
Gerrit-Change-Id: I3edf818fc9583795f3f51b715fdbe75b6a6a6964
Gerrit-Change-Number: 753701
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
open
diffy
satisfied_requirement

Carlos Amedee (Gerrit)

unread,
12:39 PM (9 hours ago) 12:39 PM
to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Mark Freeman, Alan Donovan, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[release-branch.go1.25] cmd/go/internal/cache: update trim timestamp before trimming


This reduces the chance that multiple go commands running in CI will
try to trim at the same time, causing contention and slowing things
down.

For #76314
Fixes #78057


Change-Id: I3edf818fc9583795f3f51b715fdbe75b6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/753240
Reviewed-by: Michael Matloob <mat...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Matloob <mat...@google.com>
Reviewed-by: Alan Donovan <adon...@google.com>
(cherry picked from commit 2a5890cd46e5658b5ceab6cfd7a06b3bfe947fb9)
Files:
  • M src/cmd/go/internal/cache/cache.go
Change size: S
Delta: 1 file changed, 31 insertions(+), 10 deletions(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Alan Donovan, +1 by Mark Freeman
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: go
    Gerrit-Branch: release-branch.go1.25
    Gerrit-Change-Id: I3edf818fc9583795f3f51b715fdbe75b6a6a6964
    Gerrit-Change-Number: 753640
    Gerrit-PatchSet: 5
    Gerrit-Owner: Michael Matloob <mat...@golang.org>
    Gerrit-Reviewer: Alan Donovan <adon...@google.com>
    Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages