[go] cmd/compile: fix ICE with large init function

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Jun 30, 2026, 1:06:54 PM (yesterday) Jun 30

to Cuong Manh Le, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Junyang Shao, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, Keith Randall, Jorropo, Cherry Mui, golang-co...@googlegroups.com

Gopher Robot submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Revert "cmd/compile: speedup large init function compile time"

This reverts CL 737880.

Reason to revert: the CL breaks initialization variables that emits
local variables in synthetic init function.

Fixes #80141

Change-Id: I7d5da53901b47d7000dc7794a157df720c4f8add

Reviewed-on: https://go-review.googlesource.com/c/go/+/794180

Reviewed-by: Keith Randall <k...@google.com>

Reviewed-by: Junyang Shao <shaoj...@google.com>

Reviewed-by: Jorropo <jorro...@gmail.com>

Reviewed-by: Keith Randall <k...@golang.org>

Auto-Submit: Cuong Manh Le <cuong.m...@gmail.com>

Auto-Submit: Junyang Shao <shaoj...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M src/cmd/compile/internal/noder/reader.go
M src/cmd/compile/internal/pkginit/init.go
M src/cmd/compile/internal/staticinit/sched.go

Change size: M

Delta: 3 files changed, 4 insertions(+), 56 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Junyang Shao, +2 by Jorropo, +1 by Keith Randall, +2 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages