[tools] gopls/internal/golang/stubmethods: support generic interfaces

0 views

Skip to first unread message

Alan Donovan (Gerrit)

unread,

5:41 PM (2 hours ago) 5:41 PM

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hongxiang Jiang, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Alan Donovan submitted the change

Change information

Commit message:

gopls/internal/golang/stubmethods: support generic interfaces

This CL fixes a bug in the "implement missing method" code action
when the interface is generic: previously, it would insert free
type parameters into the concrete method declarations, instead
of using their instantiations from the LHS of the failing
var I = C(...) assignment.

Also, reject attemps to implement interface types that have free
type parameters, either because they are generic, or because
they are local to a generic function and reference its type
parameters.

+ test

How should the interactive "implement interface" refactoring
work when the interface is generic? Should it prompt for a
type for each type argument? Currently it will reject it.

Also, flip incorrect got/want in marker test error message.

Fixes golang/go#79845