[tools] gopls/internal/licenses: use //go:embed rather than a hand-embedded string

1 view
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Jun 30, 2026, 6:48:02 PM (17 hours ago) Jun 30
to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Alan Donovan, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
gopls/internal/licenses: use //go:embed rather than a hand-embedded string

Avoid surprising errors (and a not-very-useful code injection mechanism)
when processing a license containing a back-quote.
Change-Id: I6295a98ba4a037b3ea05e58599befc116a6a6964
Auto-Submit: Alan Donovan <adon...@google.com>
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
  • M gopls/internal/licenses/gen-licenses.sh
  • M gopls/internal/licenses/licenses.go
  • A gopls/internal/licenses/licenses.txt
  • M gopls/internal/licenses/licenses_test.go
Change size: XL
Delta: 4 files changed, 572 insertions(+), 583 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I6295a98ba4a037b3ea05e58599befc116a6a6964
Gerrit-Change-Number: 795880
Gerrit-PatchSet: 2
Gerrit-Owner: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages