[go] cmd/compile: preserve pointerness during splitload

2 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

May 14, 2026, 6:01:09 PM (2 days ago) May 14

to Josh Bleecher Snyder, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, Keith Randall, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

cmd/compile: preserve pointerness during splitload

386 and AMD64's splitload could silently change
a pointer type to an int type. Fix that.
Add type preservation to the narrower widths for symmetry,
even though it doesn't matter in the same way there.

Change-Id: I155d136dd43989900d26f2a7f014d7300fdbb7cb

Reviewed-on: https://go-review.googlesource.com/c/go/+/777820

Reviewed-by: Keith Randall <k...@golang.org>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Reviewed-by: Keith Randall <k...@google.com>

Auto-Submit: Keith Randall <k...@golang.org>

Files:

M src/cmd/compile/internal/ssa/_gen/386splitload.rules
M src/cmd/compile/internal/ssa/_gen/AMD64splitload.rules
M src/cmd/compile/internal/ssa/rewrite386splitload.go
M src/cmd/compile/internal/ssa/rewriteAMD64splitload.go
A test/fixedbugs/splitload_pointer_compare.go

Change size: M

Delta: 5 files changed, 82 insertions(+), 48 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Keith Randall, +1 by Dmitri Shuralyov, +2 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages