[go] internal/trace: add command to convert text traces to raw

[Michael Pratt (Gerrit)]

Michael Pratt submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/internal/trace/testtrace/helpers_test.go
Insertions: 1, Deletions: 1.

@@ -22,7 +22,7 @@
 // text dumps generated by Dump into the binary trace format. Set -convert and
 // -o to perform a converison.
 //
-//  go test internal/trace/testtrace -convert in.tracetxt -o out.trace
+//  go test internal/trace/testtrace -convert in.tracetxt -out out.trace
 //
 // This would be cleaner as a dedicated internal command rather than a test,
 // but cmd/dist does not handle internal (non-distributed) commands in std
```

Change information

Commit message:

internal/trace: add "command" to convert text traces to raw

This is primarily helpful for parsing traces dumped via CI.

cmd/dist doesn't like commands in std which are not actually part of the
Go distribution. So rather than using a real command, this is actually a
test which does the conversion.

Change-Id: I6a6a636c829a4acc0bce8cf7548105ad59d83c67

Reviewed-on: https://go-review.googlesource.com/c/go/+/716882

Reviewed-by: Michael Knyszek <mkny...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• M src/internal/trace/testtrace/helpers.go
• A src/internal/trace/testtrace/helpers_test.go

Change size: M

Delta: 2 files changed, 80 insertions(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Michael Knyszek
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I6a6a636c829a4acc0bce8cf7548105ad59d83c67

Gerrit-Change-Number: 716882

Gerrit-PatchSet: 5

Gerrit-Owner: Michael Pratt <mpr...@google.com>

Gerrit-Reviewer: Carlos Amedee <car...@golang.org>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>

Gerrit-Reviewer: Michael Pratt <mpr...@google.com>