[go] archive/zip: fix reader-side Zip64 edge cases

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

1:10 PM (5 hours ago) 1:10 PM

to Filippo Valsorda, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Russ Cox, Joseph Tsai, Brad Fitzpatrick, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

archive/zip: fix reader-side Zip64 edge cases

The 0xffff directorySize was a typo, and File.zip64 was unused.

The ErrFormat was intentional, but it's actually possible to have a
valid zip file with compressed size 2³²-1, for example by storing
uncompressed a file of size 2³²-1 using Info-ZIP. The following CL
introduces a couple such files (infozip-store-4g-minus-1 and
infozip-offset-eq-4g).

Fixes #31692
Fixes #56249
Updates #14185
Updates #13367
Updates #13166

Change-Id: I503805cace50316a665633d43dcc7fa46a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/779180

Reviewed-by: Russ Cox <r...@golang.org>

Reviewed-by: David Chase <drc...@google.com>

Auto-Submit: Filippo Valsorda <fil...@golang.org>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M src/archive/zip/reader.go
M src/archive/zip/zip_test.go

Change size: M

Delta: 2 files changed, 24 insertions(+), 34 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Russ Cox, +1 by David Chase
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages