[go] cmd/compile: (mips64x) optimize float32(abs|sqrt64(float64(x)))

0 views
Skip to first unread message

Julian Zhu (Gerrit)

unread,
4:13 AM (16 hours ago) 4:13 AM
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Joel Sing, Dmitri Shuralyov, David Chase, Go LUCI, Gopher Robot, golang-co...@googlegroups.com

Julian Zhu submitted the change

Change information

Commit message:
cmd/compile: (mips64x) optimize float32(abs|sqrt64(float64(x)))

Absorb unnecessary conversion between float32 and float64
if both src and dst are 32 bit.

Ref: CL 733621
Updates #75463
Change-Id: I439f92aa3d940fa4979e76845c0893e43bf584af
Reviewed-by: David Chase <drc...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Joel Sing <jo...@sing.id.au>
Files:
  • M src/cmd/compile/internal/mips64/ssa.go
  • M src/cmd/compile/internal/ssa/_gen/MIPS64.rules
  • M src/cmd/compile/internal/ssa/_gen/MIPS64Ops.go
  • M src/cmd/compile/internal/ssa/opGen.go
  • M src/cmd/compile/internal/ssa/rewriteMIPS64.go
Change size: M
Delta: 5 files changed, 55 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by David Chase, +1 by Dmitri Shuralyov, +2 by Joel Sing
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I439f92aa3d940fa4979e76845c0893e43bf584af
Gerrit-Change-Number: 739520
Gerrit-PatchSet: 3
Gerrit-Owner: Julian Zhu <jz53...@gmail.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-CC: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages