[go] cmd/compile/internal/noder: unnecessary assignment to the blank identifier

410 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Sep 29, 2022, 9:35:59 PM9/29/22
to xie cui, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Robert Griesemer, Robert Griesemer, Matthew Dempsky, Martin Möhrmann, Keith Randall, golang-co...@googlegroups.com

Gopher Robot submitted this change.

View Change


Approvals: xie cui: Run TryBots Gopher Robot: TryBots succeeded Robert Griesemer: Looks good to me, approved; Run TryBots; Automatically submit change Ian Lance Taylor: Looks good to me, but someone else must approve
cmd/compile/internal/noder: remove unnecessary assignment to the blank identifier

Change-Id: I51dd087e630bf433c30d0aaaf3715b62524eb432
Reviewed-on: https://go-review.googlesource.com/c/go/+/436647
Auto-Submit: Robert Griesemer <g...@google.com>
Run-TryBot: xie cui <5235...@qq.com>
Reviewed-by: Robert Griesemer <g...@google.com>
TryBot-Result: Gopher Robot <go...@golang.org>
Run-TryBot: Robert Griesemer <g...@google.com>
Reviewed-by: Ian Lance Taylor <ia...@google.com>
---
M src/cmd/compile/internal/noder/stencil.go
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/cmd/compile/internal/noder/stencil.go b/src/cmd/compile/internal/noder/stencil.go
index 91c0edf..8fd40fb 100644
--- a/src/cmd/compile/internal/noder/stencil.go
+++ b/src/cmd/compile/internal/noder/stencil.go
@@ -547,7 +547,7 @@
// Lookup the method on the base generic type, since methods may
// not be set on imported instantiated types.
baseType := typ.OrigType()
- for j, _ := range typ.Methods().Slice() {
+ for j := range typ.Methods().Slice() {
if baseType.Methods().Slice()[j].Nointerface() {
typ.Methods().Slice()[j].SetNointerface(true)
}

To view, visit change 436647. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I51dd087e630bf433c30d0aaaf3715b62524eb432
Gerrit-Change-Number: 436647
Gerrit-PatchSet: 3
Gerrit-Owner: xie cui <5235...@qq.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
Gerrit-Reviewer: Matthew Dempsky <mdem...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-Reviewer: xie cui <5235...@qq.com>
Gerrit-MessageType: merged
Reply all
Reply to author
Forward
0 new messages