[go] cmd/compile: fix broken 386 softfloat builder
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Jul 16, 2026, 1:12:11 PM (yesterday) Jul 16
to Cuong Manh Le, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, Keith Randall, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, Bobu Putheeckal, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cmd/compile: fix broken 386 softfloat builder
CL 782461 added new test for avoiding temporary on non-softfloat system.
However, the test was set to be run unconditionally, thus it would be
failed on softfloat builders.
Fixing this by moving the test to be run under cmd/internal/testdir, so
it's possible to exclude unwanted softfloat platforms. While at it, also
tighten the test to ensure there would be temporary if the compiler is
forced to emit softfloat code.
Updates #28698
Fixes #80422
Cq-Include-Trybots: luci.golang.try:gotip-linux-386-softfloat
Change-Id: I5f7b3a19fe36d070d819d58cc29d43e4b44bb1fe
Reviewed-on: https://go-review.googlesource.com/c/go/+/801560
Auto-Submit: Cuong Manh Le <cuong.m...@gmail.com>
Reviewed-by: Keith Randall <k...@golang.org>
Reviewed-by: Michael Pratt <mpr...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <k...@google.com>
Files:
- D src/cmd/compile/testdata/script/issue28698.txt
- A test/fixedbugs/issue28698.go
Change size: M
Delta: 2 files changed, 80 insertions(+), 15 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Michael Pratt, +2 by Keith Randall, +1 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages