[tools] gopls/internal/test/integration/misc: relax match for fmt.newPrinter

0 views

Skip to first unread message

Alan Donovan (Gerrit)

unread,

2:17 PM (9 hours ago) 2:17 PM

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

Alan Donovan submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

gopls/internal/test/integration/misc: relax match for fmt.newPrinter

CL 709235 for making the fmt.Append* functions actually efficient
requires changing the newPrinter signature internal to fmt.
Relax the regression to allow for the new signature.

Change-Id: Ic1e57250b26151e335968681a8652e720efe90ed

Reviewed-on: https://go-review.googlesource.com/c/tools/+/754600

Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>

Reviewed-by: Alan Donovan <adon...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M gopls/internal/test/integration/misc/definition_test.go

Change size: XS

Delta: 1 file changed, 3 insertions(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Hyang-Ah Hana Kim, +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages