[tools] gopls/internal/util/frob: change Codec.Decode to return the value

0 views

Skip to first unread message

Robert Findley (Gerrit)

unread,

Apr 14, 2026, 10:48:54 AM (yesterday) Apr 14

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, golang...@luci-project-accounts.iam.gserviceaccount.com, Alan Donovan, golang-co...@googlegroups.com

Robert Findley submitted the change

Change information

Commit message:

gopls/internal/util/frob: change Codec.Decode to return the value

Change Codec[T].Decode from Decode(data, *T) to Decode(data) T. This
reads more naturally at every call site and lets the method value be
passed directly as a filecache.Get decoder.

Change-Id: I9912fb96b468a7b993174351110a89e021c74038

Reviewed-on: https://go-review.googlesource.com/c/tools/+/764240

Reviewed-by: Alan Donovan <adon...@google.com>

Reviewed-by: David Chase <drc...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M gopls/internal/cache/analysis.go
M gopls/internal/cache/errors.go
M gopls/internal/cache/methodsets/methodsets.go
M gopls/internal/cache/symbols/symbols.go
M gopls/internal/cache/testfuncs/tests.go
M gopls/internal/cache/typerefs/refs.go
M gopls/internal/cache/xrefs/xrefs.go
M gopls/internal/filewatcher/poll_watcher.go
M gopls/internal/settings/settings.go
M gopls/internal/util/frob/frob.go
M gopls/internal/util/frob/frob_test.go

Change size: M

Delta: 11 files changed, 23 insertions(+), 38 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by David Chase, +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages