[protobuf] Update protobuf to v35.1 so integration tests pass when run to build protoc and conformance test runner using Bazel 9

1 view

Skip to first unread message

Nicolas Hillegeer (Gerrit)

unread,

Aug 6, 2026, 2:29:44 AM (4 days ago) Aug 6

to Sandy Zhang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Gopher Robot, SLSA Policy Verification Service, golang-co...@googlegroups.com

Nicolas Hillegeer submitted the change

Change information

Commit message:

protoc: update to the protobuf version (35.1)

The integration (conformance) tests are broken on Bazel 9 (latest Bazel), which Protobuf version v33.3 does not support:

.cache/bazel/_bazel_sandyzhang/1ca2a7e8387de5728aca845a644fe834/external/rules_go+/go/private/rules/cgo.bzl:191:22: The CcInfo symbol has been removed, add the following to your BUILD/bzl file:

Protobuf has supported Bazel 9 since v35.

The failing integration tests prevent us from tagging a new release.

For the time being, using v35.1 version requires Bazel flags
--//bazel/flags:prefer_prebuilt_protoc=false and
--//bazel/flags:allow_nonstandard_protoc due to newer protobuf versions defaulting to prebuilt protoc which is only intended to work using Bazel Central Registry (e.g. .bazel.tar.gz release artifact instead of the v35.1 tag checked out here). This will be fixed at a later time, but for now just disable it.

Updates #1711.

Change-Id: Ied92b64bcbd1daf8a6ab4b0e462a4ec226da4358

Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/810580

Reviewed-by: Nicolas Hillegeer <ak...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Files:

M cmd/protoc-gen-go/feature_resolution_test/test_features_defaults.binpb
M integration_test.go
M internal/conformance/failing_tests.txt
M internal/editiondefaults/editions_defaults.binpb
M internal/genid/descriptor_gen.go
M internal/testprotos/conformance/editions/test_messages_edition2023.pb.go
M internal/testprotos/conformance/editionsmigration/test_messages_proto2_editions.pb.go
M internal/testprotos/conformance/editionsmigration/test_messages_proto3_editions.pb.go
M internal/testprotos/conformance/editionunstable/test_messages_edition_unstable.pb.go
M internal/testprotos/conformance/test_messages_proto2.pb.go
M internal/testprotos/conformance/test_messages_proto3.pb.go
M reflect/protoreflect/source_gen.go
M types/descriptorpb/descriptor.pb.go
M types/known/anypb/any.pb.go
M types/known/fieldmaskpb/field_mask.pb.go
M types/known/structpb/struct.pb.go
M types/known/timestamppb/timestamp.pb.go

Change size: L

Delta: 17 files changed, 553 insertions(+), 363 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Nicolas Hillegeer
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages