[pkgsite] all, go.mod: manage staticcheck and unparam via go tool

0 views

Skip to first unread message

Hyang-Ah Hana Kim (Gerrit)

unread,

Jun 30, 2026, 12:46:30 PM (23 hours ago) Jun 30

to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Ethan Lee, Jonathan Amsterdam, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Hyang-Ah Hana Kim submitted the change

Change information

Commit message:

all, go.mod: manage linters via go tool

Add staticcheck, unparam, misspell, and go-template-lint as tool
dependencies in go.mod so they compile against our module graph.
Update all.bash to run them via go tool and remove ensure_go_binary.
Fix linter issues caught by updated staticcheck in database.go
(SA9010) and playground.go (SA1019).

For golang/go#79987

Change-Id: I9e3cb52d3623f2bcf0f8a84024323fe25b1c1b79

Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/795580

Reviewed-by: Ethan Lee <etha...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

kokoro-CI: kokoro <noreply...@google.com>

Files:

M all.bash
M go.mod
M go.sum
M internal/database/database.go
M internal/frontend/playground.go

Change size: M

Delta: 5 files changed, 44 insertions(+), 36 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Ethan Lee
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
kokoro-CI-Passes: kokoro-CI+1 by kokoro

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages