[tools] gopls: fix SignatureHelp activeParameter not being passed

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Jul 8, 2025, 11:19:11 AMJul 8

to skewb1k, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Robert Findley, Go LUCI, Alan Donovan, Jake Bailey, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

gopls: fix SignatureHelp activeParameter not being passed

Fixes golang/go#74329

Change-Id: Icc30b86c2443e7dab920688438c29543b0ede41d

Reviewed-on: https://go-review.googlesource.com/c/tools/+/683135

Auto-Submit: Alan Donovan <adon...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Robert Findley <rfin...@google.com>

Reviewed-by: Alan Donovan <adon...@google.com>

Files:

M gopls/internal/golang/signature_help.go
M gopls/internal/protocol/generate/tables.go
M gopls/internal/protocol/tsprotocol.go
M gopls/internal/server/signature_help.go
M gopls/internal/test/marker/testdata/completion/snippet.txt
M gopls/internal/test/marker/testdata/completion/snippet_placeholder.txt
M gopls/internal/test/marker/testdata/completion/testy.txt
M gopls/internal/test/marker/testdata/signature/generic.txt
M gopls/internal/test/marker/testdata/signature/issue69552.txt
M gopls/internal/test/marker/testdata/signature/signature.txt
M internal/expect/extract.go

Change size: M

Delta: 11 files changed, 117 insertions(+), 110 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Robert Findley, +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages