[go] cmd/compile/internal/bitvec: use chunked allocation in NewBulk
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Feb 12, 2026, 12:29:12 PM (18 hours ago) Feb 12
to Michael Podtserkovskii, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Junyang Shao, Go LUCI, Keith Randall, Keith Randall, Robert Griesemer, Matthew Dempsky, Martin Möhrmann, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cmd/compile/internal/bitvec: remove 2GB allocation limit in NewBulk
Remove the "NewBulk too big" check that prevented bulk bit vector
allocations exceeding ~2GB. This limit was overly restrictive and
caused compilation failures for large generated code.
The actual constraint is in the runtime's stackmap reader, which uses
int32 arithmetic. Add overflow checks in cmd/compile/internal/liveness
before stackmap serialization to detect this condition, allowing
NewBulk itself to allocate bulk large bit vector.
Fixes #77170
Change-Id: Ib7f2cabb28683258fc4e85418ba7fa70b48620b0
Reviewed-on: https://go-review.googlesource.com/c/go/+/736240
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <k...@golang.org>
Auto-Submit: Keith Randall <k...@golang.org>
Reviewed-by: Keith Randall <k...@google.com>
Reviewed-by: Junyang Shao <shaoj...@google.com>
Files:
- M src/cmd/compile/internal/bitvec/bv.go
- M src/cmd/compile/internal/liveness/arg.go
- M src/cmd/compile/internal/liveness/plive.go
Change size: S
Delta: 3 files changed, 27 insertions(+), 7 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Keith Randall, +1 by Junyang Shao, +2 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages