[All-Projects/refs/meta/config] project.config: show trybot and unresolved comment submit requirements
2 views
Skip to first unread message
Dmitri Shuralyov (Gerrit)
Jan 2, 2024, 3:44:04 PM1/2/24
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek
Dmitri Shuralyov submitted this change.
Approvals:
Michael Knyszek: Looks good to me, approved
project.config: show trybot and unresolved comment submit requirements
The following submit requirements are generally applicable and relevant
in all CLs that go through the Go code review process:
• Code-Review
• TryBots-Pass (and the temporary LUCI-Pass vote used during migration)
• No-Unresolved-Comments
• Review-Enforcement
That is, these submit requirements start out being unmet¹, and all four
of them need to eventually be satisfied before a CL can be submitted.
It seems detrimental to the dev UX to hide them after they're met.
The other submit requirements, such as No-Holds, No-Wait-Release,
Do-Not-Review, Matching-Subject-Prefix, and others are more situational:
they apply in rare cases, and it's fine for them not to show up whenever
they're satisfied.
Refactor our uses of applicableIf and submittableIf to make the above
happen. Also arrange all the visible-when-satisfied submit requirements
to be on top, and all the hidden-unless-unsatisfied submit requirements
to be on at the bottom.
¹ No-Unresolved-Comments technically starts out being met, but I think
it's an important and visible part of the Go code review process to be
promoted to be always visible. We can always change it later if wished.
Change-Id: I1216494c8d985e1af21488339fb7d33c616d4c75
Reviewed-on: https://go-review.googlesource.com/c/All-Projects/+/537736
Reviewed-by: Michael Knyszek <mkny...@google.com>
---
M project.config
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/project.config b/project.config
index d3a5adc..4efe252 100644
--- a/project.config
+++ b/project.config
@@ -180,6 +180,27 @@
email = goph...@pubsubhelper.golang.org
[plugin "jwtservice"]
audience = https://api.cr.dev
+[submit-requirement "Code-Review"]
+ description = At least one Code-Review+2 is required. Self review is not allowed.
+ submittableIf = label:Code-Review=MAX,user=non_uploader
+ canOverrideInChildProjects = true
+[submit-requirement "TryBots-Pass"]
+ description = Changes must pass TryBots unless TryBot-Bypass+1 is set.
+ applicableIf = -branch:refs/meta/config
+ submittableIf = label:LUCI-TryBot-Result=MAX OR label:TryBot-Result=MAX
+ overrideIf = label:TryBot-Bypass=MAX
+ canOverrideInChildProjects = true
+[submit-requirement "LUCI-Pass"]
+ description = Changes on release branches must pass LUCI unless TryBot-Bypass+1 is set.
+ applicableIf = branch:\"^refs/heads/release-branch.+\"
+ submittableIf = label:LUCI-TryBot-Result=MAX
+ overrideIf = label:TryBot-Bypass=MAX
+ canOverrideInChildProjects = true
+[submit-requirement "No-Unresolved-Comments"]
+ description = Changes that have unresolved comments are not submittable, unless overriden by adding the hashtag allow-unresolved-comments.
+ submittableIf = -has:unresolved
+ overrideIf = hashtag:allow-unresolved-comments
+ canOverrideInChildProjects = false
[submit-requirement "Do-Not-Submit"]
description = Changes that have DO NOT SUBMIT in their commit message are not submittable.
applicableIf = message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\"
@@ -190,31 +211,10 @@
applicableIf = message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (R|r)(E|e)(V|v)(I|i)(E|e)(W|w).*\"
submittableIf = is:false
canOverrideInChildProjects = false
-[submit-requirement "Code-Review"]
- description = At least one Code-Review+2 is required. Self review is not allowed.
- submittableIf = label:Code-Review=MAX,user=non_uploader
- canOverrideInChildProjects = true
[submit-requirement "No-Holds"]
description = Changes with a Hold+1 vote are not submittable.
- submittableIf = NOT label:Hold=1
- canOverrideInChildProjects = false
-[submit-requirement "TryBots-Pass"]
- description = Changes must pass TryBots unless TryBot-Bypass+1 is set.
- applicableIf = -branch:refs/meta/config -(label:LUCI-TryBot-Result=MAX OR label:TryBot-Result=MAX)
+ applicableIf = label:Hold=1
submittableIf = is:false
- overrideIf = label:TryBot-Bypass=MAX
- canOverrideInChildProjects = true
-[submit-requirement "LUCI-Pass"]
- description = Changes on release branches must pass LUCI unless TryBot-Bypass+1 is set.
- applicableIf = branch:\"^refs/heads/release-branch.+\" -label:LUCI-TryBot-Result=MAX
- submittableIf = is:false
- overrideIf = label:TryBot-Bypass=MAX
- canOverrideInChildProjects = true
-[submit-requirement "No-Unresolved-Comments"]
- description = Changes that have unresolved comments are not submittable, unless overriden by adding the hashtag allow-unresolved-comments.
- applicableIf = has:unresolved
- submittableIf = -has:unresolved
- overrideIf = hashtag:allow-unresolved-comments
canOverrideInChildProjects = false
[submit-requirement "No-Wait-Release"]
description = Changes with the hashtag wait-release cannot be submitted.
To view, visit change 537736. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages