[tools] gopls/internal/test/integration/completion: fix flaky TestUnimportedCompletion_VSCodeIssue3365
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Feb 24, 2026, 3:48:43 PM (12 hours ago) Feb 24
to Francisco Ferraz, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Go LUCI, Madeline Kalil, Alan Donovan, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/test/integration/completion: fix flaky TestUnimportedCompletion_VSCodeIssue3365
The test used nested t.Run() subtests inside a runner.Run callback.
Env methods called e.TB.Fatal() on the parent subtest's t from within
a child subtest goroutine, causing "FailNow on a parent test" panics
and 20-minute timeouts.
Replace the inner t.Run() subtests with a plain loop.
Fixes golang/go#77756
Change-Id: I50cd5207dbe022a19fdd96e48d4a86e92710792c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/747461
Auto-Submit: Alan Donovan <adon...@google.com>
Reviewed-by: David Chase <drc...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
- M gopls/internal/test/integration/completion/completion_test.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by David Chase, +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
Feb 24, 2026, 9:31:31 PM (6 hours ago) Feb 24
to Francisco Ferraz, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Madeline Kalil, golang-co...@googlegroups.com
Alan Donovan submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/test/integration/completion: fix flaky TestUnimportedCompletion_VSCodeIssue3365
The test used nested t.Run() subtests inside a runner.Run callback.
Env methods called e.TB.Fatal() on the parent subtest's t from within
a child subtest goroutine, causing "FailNow on a parent test" panics
and 20-minute timeouts.
Replace the inner t.Run() subtests with a plain loop.
Fixes golang/go#77756
Change-Id: I37e1c77606981665bdb762316da3b02b5c6505fc
Reviewed-on: https://go-review.googlesource.com/c/tools/+/748620
Reviewed-by: Alan Donovan <adon...@google.com>
Commit-Queue: Alan Donovan <adon...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adon...@google.com>
Reviewed-by: Madeline Kalil <mka...@google.com>
Files:
- M gopls/internal/test/integration/completion/completion_test.go
Change size: S
Delta: 1 file changed, 11 insertions(+), 14 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Madeline Kalil, +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages