[go] internal/poll: move isBlocking checks to inside execIO

[Quim Muntal (Gerrit)]

Quim Muntal submitted the change

Change information

Commit message:

internal/poll: move isBlocking checks to inside execIO

This is a step towards deferring adding the handle to IOCP until the
first IO operation.

Having all isBlocking checks inside execIO will make it easier to delay
getting that information until the first IO operation.

It also makes the code simpler, as Pread and Pwrite now only modify
the overlapped object offset, not the one in the FD struct, so they
don't need to reverse the offset change after the IO operation.

For #76391

Cq-Include-Trybots: luci.golang.try:gotip-windows-amd64-longtest,gotip-windows-amd64-race

Change-Id: Iea680c502c9417b9569a0b1a9da6f7e6bf916f6a

Reviewed-on: https://go-review.googlesource.com/c/go/+/742283

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Damien Neil <dn...@google.com>

Reviewed-by: Michael Pratt <mpr...@google.com>

Files:

• M src/internal/poll/fd_windows.go

Change size: M

Delta: 1 file changed, 31 insertions(+), 36 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Damien Neil, +1 by Michael Pratt
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Iea680c502c9417b9569a0b1a9da6f7e6bf916f6a

Gerrit-Change-Number: 742283

Gerrit-PatchSet: 2

Gerrit-Owner: Quim Muntal <quimm...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Pratt <mpr...@google.com>

Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>