[vuln] cmd/govulncheck: update unit tests

0 views
Skip to first unread message

Maceo Thompson (Gerrit)

unread,
4:18 PM (2 hours ago) 4:18 PM
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Zvonimir Pavlinovic, Ian Cottrell, Go LUCI, golang-co...@googlegroups.com

Maceo Thompson submitted the change

Change information

Commit message:
cmd/govulncheck: update unit tests

Previously, unit tests using the "vuln" module did not have a
vulnerability that was imported but not called (a "package-level"
vulnerability). This change modifies main.go in the vuln module to
directly call a vulnerable function instead of using a function that
eventually was affected by multiple vulns.
Change-Id: Ic77a9c8efe3fd6dd2a2e76c230b3c4f67421e2fc
Reviewed-by: Zvonimir Pavlinovic <zpavl...@google.com>
Files:
  • M cmd/govulncheck/testdata/common/modules/vuln/go.mod
  • M cmd/govulncheck/testdata/common/modules/vuln/subdir/subdir.go
  • M cmd/govulncheck/testdata/common/modules/vuln/vuln.go
  • M cmd/govulncheck/testdata/common/testfiles/binary-call/binary_call_json.ct
  • M cmd/govulncheck/testdata/common/testfiles/binary-call/binary_call_text.ct
  • M cmd/govulncheck/testdata/common/testfiles/binary-call/binary_sarif.ct
  • M cmd/govulncheck/testdata/common/testfiles/binary-call/binary_vex.ct
  • M cmd/govulncheck/testdata/common/testfiles/source-call/source_call_json.ct
  • M cmd/govulncheck/testdata/common/testfiles/source-call/source_call_sarif.ct
  • M cmd/govulncheck/testdata/common/testfiles/source-call/source_call_text.ct
  • M cmd/govulncheck/testdata/common/testfiles/source-call/source_call_vex.ct
  • M cmd/govulncheck/testdata/common/testfiles/source-call/source_subdir_text.ct
Change size: L
Delta: 12 files changed, 99 insertions(+), 299 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Zvonimir Pavlinovic
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: vuln
Gerrit-Branch: master
Gerrit-Change-Id: Ic77a9c8efe3fd6dd2a2e76c230b3c4f67421e2fc
Gerrit-Change-Number: 599476
Gerrit-PatchSet: 2
Gerrit-Owner: Maceo Thompson <maceot...@google.com>
Gerrit-Reviewer: Maceo Thompson <maceot...@google.com>
Gerrit-Reviewer: Zvonimir Pavlinovic <zpavl...@google.com>
Gerrit-CC: Ian Cottrell <ianco...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages