[go] cmd/compile: adjust compiler to allow for embedded field selectors

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Mar 19, 2026, 8:16:43 PM (24 hours ago) Mar 19
to Robert Griesemer, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Mark Freeman, Keith Randall, Robert Griesemer, golang-co...@googlegroups.com

Gopher Robot submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
cmd/compile: enable promoted field selectors as keys in struct literals

Switch the generated UIR version from V2 to V3.
Adjust cmd/compile/internal/types to accept promoted field selectors
in composite literals.

Fixes #9859.
Change-Id: Ie314e28567cfa6cf4c9e962a07b32dd05b06bf5e
Auto-Submit: Robert Griesemer <g...@google.com>
Reviewed-by: Mark Freeman <markf...@google.com>
Reviewed-by: Keith Randall <k...@golang.org>
Files:
  • M src/cmd/compile/internal/noder/unified.go
  • M src/cmd/compile/internal/typecheck/expr.go
  • M src/cmd/compile/internal/walk/complit.go
  • A test/complit2.go
Change size: M
Delta: 4 files changed, 55 insertions(+), 6 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Keith Randall, +1 by Mark Freeman
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ie314e28567cfa6cf4c9e962a07b32dd05b06bf5e
Gerrit-Change-Number: 755740
Gerrit-PatchSet: 6
Gerrit-Owner: Robert Griesemer <g...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages