[go] go/types, types2: set underlying for imported types

[Mark Freeman (Gerrit)]

Mark Freeman submitted the change

Change information

Commit message:

go/types, types2: set underlying for imported types

Importing generic methods with recursive bounds can currently deadlock.
This is because SetConstraint, which is called from a delayed function,
requires the underlying type. We already have this information handy,
so the fix is somewhat simple.

Credit goes to Lauro Santana for reporting this issue and contributing
a test case (attached here).

Fixes #80258

Change-Id: I06ec71edbbd113743273f7c4be15b142e2f6938c

Reviewed-on: https://go-review.googlesource.com/c/go/+/797640

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Alan Donovan <adon...@google.com>

Files:

• M src/cmd/compile/internal/types2/named.go
• A src/cmd/compile/testdata/script/issue80258.txt
• M src/go/types/named.go

Change size: M

Delta: 3 files changed, 45 insertions(+), 8 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Alan Donovan
• TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I06ec71edbbd113743273f7c4be15b142e2f6938c

Gerrit-Change-Number: 797640

Gerrit-PatchSet: 2

Gerrit-Owner: Mark Freeman <markf...@google.com>

Gerrit-Reviewer: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Mark Freeman <markf...@google.com>

Gerrit-Reviewer: Robert Griesemer <g...@google.com>

Gerrit-Reviewer: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>